package console import ( "context" "errors" "testing" "time" "github.com/carlosframework/platform/internal/objstore" "github.com/carlosframework/platform/internal/release" ) type bucketRecordingScanner struct { *objstore.MemScanner buckets []string } func (s *bucketRecordingScanner) Scan(ctx context.Context, bucket, key, version string, size int64) (objstore.Verdict, bool, error) { s.buckets = append(s.buckets, bucket) return s.MemScanner.Scan(ctx, bucket, key, version, size) } func TestRevivalDrainRereadsConsentAndBucketInsidePermit(t *testing.T) { for _, revoked := range []bool{true, false} { name := "bucket replaced" if revoked { name = "scanning revoked" } t.Run(name, func(t *testing.T) { ctx := context.Background() fx, mem, _ := drainFixture(t) scanner := &bucketRecordingScanner{MemScanner: mem} enableStore(t, fx, fixtureAcct, fixtureApp, true) oldBucket := drainBucket(fixtureAcct, fixtureApp) newBucket := oldBucket + "-replacement" key := "report.pdf" for _, bucket := range []string{oldBucket, newBucket} { scanner.PutObject(bucket, key, bucket+"-etag", time.Now(), 12) } enqueueFor(t, fx, fixtureAcct, fixtureApp, key, time.Now()) raw := fx.rel.(*release.DirStore) runner := &resultCollectionRunner{DirStore: raw} runner.before = func() { rec, etag, err := objstore.Get(ctx, raw, fixtureAcct, fixtureApp) if err != nil { t.Fatal(err) } if revoked { rec.Scanning.Enabled = nil } else { rec.Provisioned.Bucket = newBucket } if _, err := objstore.Put(ctx, raw, fixtureAcct, fixtureApp, rec, etag); err != nil { t.Fatal(err) } } _, _, err := objstore.DrainApp(ctx, runner, scanner, fx.srv.scanQueue, fixtureAcct, fixtureApp, 50, time.Now()) if revoked && !errors.Is(err, objstore.ErrQueueNotPermitted) { t.Fatalf("drain after revoke = %v", err) } if !revoked && err != nil { t.Fatal(err) } want := 1 if revoked { want = 0 } if len(scanner.buckets) != want || (want == 1 && scanner.buckets[0] != newBucket) { t.Fatalf("scanned buckets = %v, want %d calls to the replacement bucket", scanner.buckets, want) } }) } }