package console import ( "net/http/httptest" "strings" "testing" "time" "github.com/carlosframework/platform/internal/registry" ) func TestValidActivityMessage(t *testing.T) { for _, message := range []string{"", "ship the new checkout", strings.Repeat("界", activityMessageMaxRunes)} { if !validActivityMessage(message) { t.Errorf("validActivityMessage(%q) = false", message) } } for _, message := range []string{ strings.Repeat("x", activityMessageMaxRunes+1), "two\nlines", "tab\tseparated", "nul\x00byte", string([]byte{0xff}), } { if validActivityMessage(message) { t.Errorf("validActivityMessage(%q) = true", message) } } } func TestActivityDoesNotLinkPlatformAliasAsInstance(t *testing.T) { fx := newConsoleFixture(t) c := signInPaul(t, fx) host := "platform-alias.example.com" fx.addRoute(t, registry.Route{Host: host, App: "kass", Account: fx.sqid, Kind: "static", Platform: true}) if err := fx.st.RecordActivity(OpsAccountID, "kass", "paul@keymail.dev", Activity{ Action: "instance-create", TargetType: "instance", Target: host, Detail: "created instance " + host, }, time.Now()); err != nil { t.Fatal(err) } status, _, body := get(t, c, fx.u("/apps/kass/activity")) if status != 200 { t.Fatalf("status = %d", status) } if !strings.Contains(body, host) { t.Fatalf("activity target missing: %s", body) } if strings.Contains(body, `/instances/`+host) { t.Fatalf("platform alias target linked as an instance: %s", body) } } func TestCheckedActivityMessageRejectsTrailingControl(t *testing.T) { for _, message := range []string{"description\n", "\tdescription", "description\r"} { w := httptest.NewRecorder() if _, ok := checkedActivityMessage(w, message); ok || w.Code != 400 { t.Errorf("accepted %q: status %d", message, w.Code) } } if got, ok := checkedActivityMessage(httptest.NewRecorder(), " description "); !ok || got != "description" { t.Fatalf("space trimming = %q, %v", got, ok) } } func TestActivityRendersDescriptionAndCompleteAction(t *testing.T) { fx := newConsoleFixture(t) c := signInPaul(t, fx) for _, event := range []Activity{ {Action: "promote", TargetType: "channel", Target: "edge", Message: "Fix ", Detail: "promoted v3 to edge (cli)"}, {Action: "config", Message: "Update delivery configuration", Detail: "config: 2 set, 0 unset (relay) (cli)"}, {Action: "ship", TargetType: "release", Target: "v3", Message: "Publish checkout fix", Detail: "shipped v3 (cli)"}, } { if err := fx.st.RecordActivity(OpsAccountID, "kass", "paul@keymail.dev", event, time.Now()); err != nil { t.Fatal(err) } } status, _, body := get(t, c, fx.u("/apps/kass/activity")) if status != 200 { t.Fatalf("status = %d", status) } for _, want := range []string{"Fix <script>alert(1)</script>", "promoted v3 to edge (cli)", "Update delivery configuration", "config: 2 set, 0 unset (relay) (cli)", `/apps/kass/releases#version-v3`, "shipped v3 (cli)"} { if !strings.Contains(body, want) { t.Errorf("missing %q", want) } } if strings.Contains(body, "") || strings.Contains(body, "CLI promotions don") { t.Fatal("activity contains unescaped message or obsolete CLI exclusion") } } func TestActivityAppRestartBodyCompatibility(t *testing.T) { for _, body := range []string{"", "{}", `{"message":"Reload delivery configuration"}`} { t.Run(body, func(t *testing.T) { fx, token := restartFixture(t, "activity-restart-body") status, out := postBody(t, fx.ts.URL+"/api/cli/apps/bab/titogo/restart", token, body) if status != 200 { t.Fatalf("restart = %d %s", status, out) } events, err := fx.st.Events(OpsAccountID, "titogo", 10) if err != nil || len(events) != 1 { t.Fatalf("events = %+v, %v", events, err) } want := "" if strings.Contains(body, "message") { want = "Reload delivery configuration" } e := events[0] if e.Action != "restart" || e.TargetType != "app" || e.Target != "titogo" || e.Message != want || e.Detail == "" { t.Fatalf("event = %+v", e) } }) } }