package applog import ( "errors" "strings" "testing" ) // TestFamilyBuildersRefuseBadSegments: no builder in the apps/// // families can produce a key from an empty or invalid account or app, or an // empty or slash-bearing box or hour. The empty app is the regression: an // app-less route was filed under its account with app "", and the errors // shipper wrote apps/bab//errors/..., which hostops.Apps refuses to walk. func TestFamilyBuildersRefuseBadSegments(t *testing.T) { type build func(acct, app, box, hour string) (string, error) builders := map[string]build{} for _, fam := range []Family{FamilyLogs, FamilyErrors, FamilyAnalytics} { builders["FamilyPrefix/"+string(fam)] = func(acct, app, _, _ string) (string, error) { return FamilyPrefix(fam, acct, app) } builders["FamilyBoxPrefix/"+string(fam)] = func(acct, app, box, _ string) (string, error) { return FamilyBoxPrefix(fam, acct, app, box) } builders["FamilyHourPrefix/"+string(fam)] = func(acct, app, box, hour string) (string, error) { return FamilyHourPrefix(fam, acct, app, box, hour) } builders["FamilyChunkKey/"+string(fam)] = func(acct, app, box, hour string) (string, error) { return FamilyChunkKey(fam, acct, app, box, hour, 1, 2) } } builders["Prefix"] = func(acct, app, _, _ string) (string, error) { return Prefix(acct, app) } builders["BoxPrefix"] = func(acct, app, box, _ string) (string, error) { return BoxPrefix(acct, app, box) } builders["HourPrefix"] = func(acct, app, box, hour string) (string, error) { return HourPrefix(acct, app, box, hour) } builders["ChunkKey"] = func(acct, app, box, hour string) (string, error) { return ChunkKey(acct, app, box, hour, 1, 2) } // Each case breaks exactly one segment. A box or hour case only applies // to builders that take that segment: a prefix above the box level // never sees the box. cases := []struct { name string acct, app, box, hr string needsBox, needsHour bool }{ {"empty app", "bab", "", "box1", "2026-10-16-06", false, false}, {"empty account", "", "web", "box1", "2026-10-16-06", false, false}, {"invalid app", "bab", "Web/x", "box1", "2026-10-16-06", false, false}, {"invalid account", "b", "web", "box1", "2026-10-16-06", false, false}, {"empty box", "bab", "web", "", "2026-10-16-06", true, false}, {"slash in box", "bab", "web", "a/b", "2026-10-16-06", true, false}, {"empty hour", "bab", "web", "box1", "", false, true}, {"slash in hour", "bab", "web", "box1", "2026/10", false, true}, } for name, b := range builders { usesBox := !strings.HasPrefix(name, "FamilyPrefix") && name != "Prefix" usesHour := strings.Contains(name, "Hour") || strings.Contains(name, "ChunkKey") for _, c := range cases { if (c.needsBox && !usesBox) || (c.needsHour && !usesHour) { continue } key, err := b(c.acct, c.app, c.box, c.hr) if !errors.Is(err, ErrBadKeySegment) || key != "" { t.Errorf("%s with %s = (%q, %v), want (\"\", ErrBadKeySegment)", name, c.name, key, err) } } } } // TestFamilyKeysByteIdentical pins every builder's output for valid names: // the refusal must not move a single byte of a key that was already good. func TestFamilyKeysByteIdentical(t *testing.T) { m := must(t) for _, c := range []struct{ got, want string }{ {m(FamilyPrefix(FamilyErrors, "bab", "web")), "apps/bab/web/errors/"}, {m(FamilyBoxPrefix(FamilyErrors, "bab", "web", "leo-climbing")), "apps/bab/web/errors/leo-climbing/"}, {m(FamilyHourPrefix(FamilyErrors, "bab", "web", "leo-climbing", "2026-10-16-06")), "apps/bab/web/errors/leo-climbing/2026-10-16-06/"}, {m(FamilyChunkKey(FamilyErrors, "bab", "web", "leo-climbing", "2026-10-16-06", 1792015319229, 257)), "apps/bab/web/errors/leo-climbing/2026-10-16-06/0001792015319229-257.jsonl.gz"}, {m(FamilyPrefix(FamilyAnalytics, "bde", "ledgerpay")), "apps/bde/ledgerpay/analytics/"}, {m(FamilyBoxPrefix(FamilyAnalytics, "bde", "ledgerpay", "box-a")), "apps/bde/ledgerpay/analytics/box-a/"}, {m(Prefix("bde", "ledgerpay")), "apps/bde/ledgerpay/logs/"}, {m(BoxPrefix("bde", "ledgerpay", "box1")), "apps/bde/ledgerpay/logs/box1/"}, {m(HourPrefix("bde", "ledgerpay", "box1", "2026-08-10-21")), "apps/bde/ledgerpay/logs/box1/2026-08-10-21/"}, {m(ChunkKey("bde", "ledgerpay", "box1", "2026-08-10-21", 41822, 8123)), "apps/bde/ledgerpay/logs/box1/2026-08-10-21/0000000000041822-8123.jsonl.gz"}, } { if c.got != c.want { t.Errorf("key = %q, want %q", c.got, c.want) } } }